[
https://issues.apache.org/jira/browse/HBASE-28334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814153#comment-17814153
]
Nirdosh Kumar Yadav commented on HBASE-28334:
---------------------------------------------
[~bbeaudreault] I've created Pull Request
[[PR5662|https://github.com/apache/hbase/pull/5662]] to address this issue.
Please review.
> Remove unnecessary null DEFAULT_VALUE in TableDescriptorBuilder
> ---------------------------------------------------------------
>
> Key: HBASE-28334
> URL: https://issues.apache.org/jira/browse/HBASE-28334
> Project: HBase
> Issue Type: Improvement
> Reporter: Bryan Beaudreault
> Assignee: Nirdosh Kumar Yadav
> Priority: Major
> Labels: pull-request-available
>
> With ERASURE_CODING_POLICY, the default value is null (no policy). I added a
> record of that in DEFAULT_VALUES, because other settings seemed to do that.
> A null value is never stored on a HTD because our code handles removing from
> map when setting null. So we'd never have an opportunity to match against the
> DEFAULT_VALUE. If someone tried setting a string value "null", that would
> fail validation because it's not a valid policy. So there's no reason to
> record this default value. It doesn't cause a problem, but is confusing to
> anyone reading the code. Remove it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
