bbeaudreault commented on code in PR #5662:
URL: https://github.com/apache/hbase/pull/5662#discussion_r1478073743
##########
hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestTableDescriptorBuilder.java:
##########
@@ -365,8 +365,9 @@ public void testStringCustomizedValues() throws
HBaseException {
.setMemStoreFlushSize("256MB").setErasureCodingPolicy("RS-6-3-1024k").build();
assertEquals(
"'testStringCustomizedValues', " + "{TABLE_ATTRIBUTES => {DURABILITY =>
'ASYNC_WAL', "
- + "ERASURE_CODING_POLICY => 'RS-6-3-1024k', MAX_FILESIZE =>
'10737942528 B (10GB 512KB)', "
- + "MEMSTORE_FLUSHSIZE => '268435456 B (256MB)'}}, "
+ + "MAX_FILESIZE => '10737942528 B (10GB 512KB)', "
+ + "MEMSTORE_FLUSHSIZE => '268435456 B (256MB)', "
+ + "METADATA => {'ERASURE_CODING_POLICY' => 'RS-6-3-1024k'}}}, "
Review Comment:
Oh ok, this is why we want to keep it in the defaults map. This setting
should not be considered metadata. I couldn't remember this when I filled the
jira.
Thank you for the PR. Now that I see this, I think we should keep it as it
was. Maybe you can add a comment where it is added to the defaults map?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
