bbeaudreault commented on code in PR #5591:
URL: https://github.com/apache/hbase/pull/5591#discussion_r1478245286


##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptorBuilder.java:
##########
@@ -234,6 +242,7 @@ public class TableDescriptorBuilder {
     DEFAULT_VALUES.put(DURABILITY, DEFAULT_DURABLITY.name()); // use the enum 
name
     DEFAULT_VALUES.put(REGION_REPLICATION, 
String.valueOf(DEFAULT_REGION_REPLICATION));
     DEFAULT_VALUES.put(PRIORITY, String.valueOf(DEFAULT_PRIORITY));
+    DEFAULT_VALUES.put(ERASURE_CODING_POLICY, 
String.valueOf(DEFAULT_ERASURE_CODING_POLICY));

Review Comment:
   In the above jira, we realized that it's necessary to set something into the 
DEFAULT_VALUES map for this. Otherwise, it gets printed as METADATA in the 
toString representation. We added a comment to note that, and the value does 
not matter.
   
   Any other concerns on this PR @Apache9? Thanks for looking



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to