meszibalu commented on code in PR #5665:
URL: https://github.com/apache/hbase/pull/5665#discussion_r1480127348
##########
hbase-shell/src/main/ruby/shell.rb:
##########
@@ -108,6 +108,8 @@ class Shell
# exit the interactive shell and save that this
# happend via a call to exit
def exit(ret = 0)
+ # Non-deamon Netty threadpool in ZK ClientCnxnSocketNetty cannot be shut
down otherwise
+ self.hbase.shutdown
Review Comment:
If `shutdown` throws an exception then shell won't exit. Shouldn't we ignore
the exceptions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
