[
https://issues.apache.org/jira/browse/HBASE-28334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815002#comment-17815002
]
Hudson commented on HBASE-28334:
--------------------------------
Results for branch branch-3
[build #140 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/140/]:
(/) *{color:green}+1 overall{color}*
----
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/140/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/140/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/140/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add comment around erasure coding policy in DEFAULT_VALUE map
> --------------------------------------------------------------
>
> Key: HBASE-28334
> URL: https://issues.apache.org/jira/browse/HBASE-28334
> Project: HBase
> Issue Type: Improvement
> Reporter: Bryan Beaudreault
> Assignee: Nirdosh Kumar Yadav
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.6.0, 3.0.0-beta-2
>
>
> New description: Upon investigation, we realized that it's necessary to put
> ERASURE_CODING_POLICY in the DEFAULT_VALUES map so that when the
> TableDescriptor is printed as a string, that setting is not listed as
> METADATA. We added a comment to note that for future reference.
> Old description: With ERASURE_CODING_POLICY, the default value is null (no
> policy). I added a record of that in DEFAULT_VALUES, because other settings
> seemed to do that.
> A null value is never stored on a HTD because our code handles removing from
> map when setting null. So we'd never have an opportunity to match against the
> DEFAULT_VALUE. If someone tried setting a string value "null", that would
> fail validation because it's not a valid policy. So there's no reason to
> record this default value. It doesn't cause a problem, but is confusing to
> anyone reading the code. Remove it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
