[
https://issues.apache.org/jira/browse/HBASE-6393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418768#comment-13418768
]
Hadoop QA commented on HBASE-6393:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12537256/hbase-6393-v1.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 5 javac compiler warnings (more than
the trunk's current 4 warnings).
-1 findbugs. The patch appears to introduce 15 new Findbugs (version
1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/2414//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2414//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2414//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2414//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2414//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2414//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/2414//console
This message is automatically generated.
> Decouple audit event creation from storage in AccessController
> --------------------------------------------------------------
>
> Key: HBASE-6393
> URL: https://issues.apache.org/jira/browse/HBASE-6393
> Project: HBase
> Issue Type: Brainstorming
> Components: security
> Affects Versions: 0.96.0
> Reporter: Marcelo Vanzin
> Attachments: hbase-6393-v1.patch
>
>
> Currently, AccessControler takes care of both generating audit events (by
> performing access checks) and storing them (by creating a log message and
> writing it to the AUDITLOG logger).
> This makes the logging system the only way to catch audit events. It means
> that if someone wants to do something fancier (like writing these records to
> a database somewhere), they need to hack through the logging system, and
> parse the messages generated by AccessController, which is not optimal.
> The attached patch decouples generation and storage by introducing a new
> interface, used by AccessController, to log the audit events. The current,
> log-based storage is kept in place so that current users won't be affected by
> the change.
> I'm filing this as an RFC at this point, so the patch is not totally clean;
> it's on top of HBase 0.92 (which is easier for me to test) and doesn't have
> any unit tests, for starters. But the changes should be very similar on trunk
> - I don't remember changes in this particular area of the code between those
> versions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
