[
https://issues.apache.org/jira/browse/HBASE-28238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818341#comment-17818341
]
Rajeshbabu Chintaguntla edited comment on HBASE-28238 at 2/19/24 4:46 AM:
--------------------------------------------------------------------------
[~selina.yan] Pushed the changes to master and branch-3.Same changes cannot be
applied to branch-2.x branches as the updateconfiugration method still in
RSRpcServices. Could you please raise another PR for branch-2.
was (Author: rajeshbabu):
[~selina.yan] Pushed the changes to master and branch-3. It's directory not
applicable to branch-2.x branches as the updateconfiugration method still in
RSRpcServices. Could you please raise another PR for branch-2.
> rpcservice should perform some important admin operation to priority ADMIN_QOS
> ------------------------------------------------------------------------------
>
> Key: HBASE-28238
> URL: https://issues.apache.org/jira/browse/HBASE-28238
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 2.5.0
> Reporter: selina.yan
> Assignee: selina.yan
> Priority: Minor
> Labels: pull-request-available
>
> some important admin operations should be admin priority,like
> compactionSwitch,rollWALWriter,updateConfiguration.
> these operations called by admin should be considered a higher priority
> operation and given to the priority queue, but is currently considered to
> have the same priority as read or write requests. If the handle is occupied,
> the operations cannot be execute successful. For example, in our scenario,
> some abnormal phoenix sql is killed by controlling the amount of data that
> scan can filter with dynamic parameters. Abnormal sql often results in a full
> handle. In this case, the configuration cannot be dynamically modified to
> implement emergency traffic limiting.
> {code:java}
> @Override
> @QosPriority(priority = HConstants.ADMIN_QOS)
> public UpdateConfigurationResponse updateConfiguration(
> RpcController controller, UpdateConfigurationRequest request)
> throws ServiceException {{code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
