[
https://issues.apache.org/jira/browse/HBASE-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418891#comment-13418891
]
Alex Baranau commented on HBASE-6411:
-------------------------------------
Glanced over your patch. I like this way better (over initial patch at 4050):
exposing the real interface of MetricsSource (in this case master metrics).
I.e. with methods defines, not empty + hashmap.
1. What do you think about having MasterMetricsFactory available through
compat module (created by CompatibilitySingletonFactory?) which is creating
MetricsSource, like this:
interface MasterMetricsFactory {
MasterMetricsSource create(final String name, final String sessionId);
}
This way we could pass parameters and control creation of metrics source.
2. Independent on the above: how about removing BaseMetricsSource interface
from compat as we don't really need it with explicit definition of metrics in
sources? This way current BaseMetricsSourceImpl could be renamed to
MetricsRegistry and used via composition (as a field) in metrics sources
instead of realization. Thus, creating & initializing of the sources which
might be different for each could stay in metrics source implementation itself.
Including deciding on using JvmMetricsSource (I assume not every source should
create it), etc.
This way they would look as normal metricsSources from hadoop codebase, just
that they will use hbase's MetricsRegistry which allows metrics removals.
Thoughts?
> Move Master Metrics to metrics 2
> --------------------------------
>
> Key: HBASE-6411
> URL: https://issues.apache.org/jira/browse/HBASE-6411
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-6411-0.patch, HBASE-6411_concept.patch
>
>
> Move Master Metrics to metrics 2
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
