Apache9 commented on code in PR #5700:
URL: https://github.com/apache/hbase/pull/5700#discussion_r1501953632
##########
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/RegionSizeCalculator.java:
##########
@@ -82,8 +81,8 @@ private void init(RegionLocator regionLocator, Admin admin)
throws IOException {
regionLocator.getName())) {
byte[] regionId = regionLoad.getRegionName();
- long regionSizeBytes =
- ((long) regionLoad.getStoreFileSize().get(Size.Unit.MEGABYTE)) *
MEGABYTE;
+ long regionSizeBytes = (long)
regionLoad.getMemStoreSize().get(Size.Unit.BYTE)
Review Comment:
Why we use Unit.MEGABYTE and then multiply 1024 * 1024 in the past? Can you
find any related issues about this? Seems strange...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
