aalhour commented on PR #5699:
URL: https://github.com/apache/hbase/pull/5699#issuecomment-1966464798
I'm wondering what the byte constant would hold, other than `0`:
- If it held `1`, it would mean that regions that no longer exist would
still get reported with size (maybe?)
- I'm having trouble understanding tests about inexistent regions and how
HBase reacts to them eventually
- If it held `-1`, we'd need to refactor the callers to handle the `< 0`
case, which will make "UNKNOWN REGIONS" more explicit with comments
Alternatively, if we return the average size of all other regions might be
good but it will push the idea of a region in transition too deep into the
RegionSizeCalculator and other areas won't know about it, maybe they should?
What if there are currently no regions available? What if there is one (or
more) region in transition and the size map is empty? What if the size map only
contains a region that's empty? I am not sure if these cases are realistic, I'm
still new to the codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
