ndimiduk commented on code in PR #5709:
URL: https://github.com/apache/hbase/pull/5709#discussion_r1505666991


##########
hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureExecutor.java:
##########
@@ -326,10 +326,11 @@ public ProcedureExecutor(final Configuration conf, final 
TEnvironment environmen
   }
 
   private void load(final boolean abortOnCorruption) throws IOException {
-    Preconditions.checkArgument(completed.isEmpty(), "completed not empty");
-    Preconditions.checkArgument(rollbackStack.isEmpty(), "rollback state not 
empty");
-    Preconditions.checkArgument(procedures.isEmpty(), "procedure map not 
empty");
-    Preconditions.checkArgument(scheduler.size() == 0, "run queue not empty");
+    Preconditions.checkArgument(completed.isEmpty(), "completed not empty: 
%s", completed);
+    Preconditions.checkArgument(rollbackStack.isEmpty(), "rollback state not 
empty: %s",
+      rollbackStack);
+    Preconditions.checkArgument(procedures.isEmpty(), "procedure map not 
empty: %s", procedures);
+    Preconditions.checkArgument(scheduler.size() == 0, "scheduler queue not 
empty: %s", scheduler);

Review Comment:
   All this `toString` business is so that we can have meaningful output here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to