DieterDP-ng commented on code in PR #5718:
URL: https://github.com/apache/hbase/pull/5718#discussion_r1507544967
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/RestoreTablesClient.java:
##########
@@ -173,7 +173,8 @@ private void restoreImages(BackupImage[] images, TableName
sTable, TableName tTa
}
if (dirList.isEmpty()) {
- LOG.warn("Nothing has changed, so there is no need to restore '" +
sTable + "'");
+ LOG.info("No incremental changes since full backup for '" + sTable
Review Comment:
No objections to parameterized logging, but the remainder of the file also
does not use that.
I dislike "since last full", since there might be a more recent full backup
that is unrelated to the incremental backup that is being recovered.
Also, to put this into context, there is a single logging message earlier in
this method:
```
LOG.info("Restoring '" + sTable + "' to '" + tTable + "' from full" + "
backup image "
+ tableBackupPath.toString());
```
So, keeping that in mind, I think it makes sense to just use "full backup".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
