bbeaudreault commented on code in PR #5691:
URL: https://github.com/apache/hbase/pull/5691#discussion_r1494464477
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java:
##########
@@ -2726,16 +2726,20 @@ protected void run() throws IOException {
MasterQuotaManager quotaManager = getMasterQuotaManager();
if (quotaManager != null) {
if (quotaManager.isQuotaInitialized()) {
- SpaceQuotaSnapshot currSnapshotOfTable =
-
QuotaTableUtil.getCurrentSnapshotFromQuotaTable(getConnection(), tableName);
- if (currSnapshotOfTable != null) {
- SpaceQuotaStatus quotaStatus =
currSnapshotOfTable.getQuotaStatus();
- if (
- quotaStatus.isInViolation()
- && SpaceViolationPolicy.DISABLE ==
quotaStatus.getPolicy().orElse(null)
- ) {
- throw new AccessDeniedException("Enabling the table '" +
tableName
- + "' is disallowed due to a violated space quota.");
+ // skip checking quotas for hbase:quota table, see:
+ // https://issues.apache.org/jira/browse/HBASE-28183
+ if (!tableName.equals(QuotaUtil.QUOTA_TABLE_NAME)) {
Review Comment:
Let's extend this to all system tables. I think you can do isSystemTable.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
