Apache9 commented on code in PR #5705:
URL: https://github.com/apache/hbase/pull/5705#discussion_r1513943462
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/AbstractMemStore.java:
##########
@@ -376,6 +376,15 @@ ImmutableSegment getSnapshot() {
return snapshot;
}
+ @Override
+ public void close() {
+ // active should never be null
+ active.close();
+ // for snapshot, either it is empty, where we do not reference any real
segment which contains a
Review Comment:
I was thinking the same way when implementing this patch but it is not easy
to get things right. It requires a big refactoring, on how we do ref counting
here. So I prefer we fix the problem first to see there are still other leaks,
and open another issue for refactoring. The latter one will take some time,
since the code is not easy to fully understand...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
