[ 
https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13419724#comment-13419724
 ] 

Lars Hofhansl commented on HBASE-5547:
--------------------------------------

Ok. On more question I asked just now on RB:

>From Matteo:
{quote}
MasterFileSystem contains deleteRegion() and deleteTable() that calls 
fs.delete() with the recursive flag on.
This two methods get called by DeleteTableHandler (drop table).
In a backup/snapshot situation we want to keep the regions/hfiles.
{quote}

My follow up question:
{quote}
        I find that deleteRegion() was addressed, but not deleteTable().

        That means if a table is dropped the HFiles would be deleted and not 
archived.
        So it seems we should either:
        - also delete the table's archive directory (since it would be 
incomplete anyway).
        - archive all the HFile before deleting them.

        What do you think Jesse?
{quote}


                
> Don't delete HFiles when in "backup mode"
> -----------------------------------------
>
>                 Key: HBASE-5547
>                 URL: https://issues.apache.org/jira/browse/HBASE-5547
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Lars Hofhansl
>            Assignee: Jesse Yates
>             Fix For: 0.94.2
>
>         Attachments: 5547-v12.txt, 5547-v16.txt, hbase-5447-v8.patch, 
> hbase-5447-v8.patch, hbase-5547-v9.patch, java_HBASE-5547_v13.patch, 
> java_HBASE-5547_v14.patch, java_HBASE-5547_v15.patch, 
> java_HBASE-5547_v4.patch, java_HBASE-5547_v5.patch, java_HBASE-5547_v6.patch, 
> java_HBASE-5547_v7.patch
>
>
> This came up in a discussion I had with Stack.
> It would be nice if HBase could be notified that a backup is in progress (via 
> a znode for example) and in that case either:
> 1. rename HFiles to be delete to <file>.bck
> 2. rename the HFiles into a special directory
> 3. rename them to a general trash directory (which would not need to be tied 
> to backup mode).
> That way it should be able to get a consistent backup based on HFiles (HDFS 
> snapshots or hard links would be better options here, but we do not have 
> those).
> #1 makes cleanup a bit harder.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to