[
https://issues.apache.org/jira/browse/HBASE-28456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830868#comment-17830868
]
Ruben Van Wanzeele edited comment on HBASE-28456 at 3/26/24 10:29 AM:
----------------------------------------------------------------------
Hi Bryan,
The good news is, your fix is valid for the incremental issue too, see test
added.
I did add a fix for HBASE-28412 where there is an issue for the incremental
restore
See patch attached. Hope it helps.
was (Author: rubenvw):
Hi Bryan,
The good news is, your fix is valid for the incremental issue too
I did add a fix for HBASE-28412 where there is an issue for the incremental
restore
See patch attached. Hope it helps.
> HBase Restore restores old data if data for the same timestamp is in
> different hfiles
> -------------------------------------------------------------------------------------
>
> Key: HBASE-28456
> URL: https://issues.apache.org/jira/browse/HBASE-28456
> Project: HBase
> Issue Type: Bug
> Components: backup&restore
> Affects Versions: 2.6.0, 3.0.0
> Reporter: Ruben Van Wanzeele
> Assignee: Bryan Beaudreault
> Priority: Blocker
> Labels: pull-request-available
> Attachments:
> Add_incremental_test_for_HBASE-28456_Fix_HBASE-28412_for_incremental_test.patch,
> ChangesOnHFilesOnSameTimestampAreNotCorrectlyRestored.java
>
>
> The restore brings back 'old' data when executing restore.
> It feels like the hfile sequence id is not respected during the restore.
> See testing code attached. The workaround solution is to trigger major
> compaction before doing the backup (not really feasible for daily backups)
> We didn't investigate this yet, but this might also impact the merge of
> multiple incremental backups (since that follows a similar code path merging
> hfiles).
> This currently blocks our support for HBase backup and restore.
> Willing to participate in a solution if necessary.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
