kadirozde commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1545469228
########## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileWriter.java: ########## @@ -256,156 +234,571 @@ public void appendMobMetadata(SetMultimap<TableName, String> mobRefSet) throws I public void appendTrackedTimestampsToMetadata() throws IOException { // TODO: The StoreFileReader always converts the byte[] to TimeRange // via TimeRangeTracker, so we should write the serialization data of TimeRange directly. - appendFileInfo(TIMERANGE_KEY, TimeRangeTracker.toByteArray(timeRangeTracker)); - appendFileInfo(EARLIEST_PUT_TS, Bytes.toBytes(earliestPutTs)); + liveFileWriter.appendTrackedTimestampsToMetadata(); Review Comment: I did not change the existing behavior. I refactored the code such that the exiting StoreFileWriter implementation was moved to the new nested class called SingleStoreFileWriter. StoreFileWriter has now two SingleStoreFileWriter objects, liveFileWriter, and historicalFileWriter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org