ndimiduk commented on code in PR #5770: URL: https://github.com/apache/hbase/pull/5770#discussion_r1547505922
########## hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcConnectionRegistryCreator.java: ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.client; + +import java.io.IOException; +import java.net.URI; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hbase.security.User; +import org.apache.yetus.audience.InterfaceAudience; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Connection registry creator implementation for creating {@link RpcConnectionRegistry}. + */ [email protected] +public class RpcConnectionRegistryCreator implements ConnectionRegistryCreator { + + private static final Logger LOG = LoggerFactory.getLogger(RpcConnectionRegistryCreator.class); + + @Override + public ConnectionRegistry create(URI uri, Configuration conf, User user) throws IOException { + assert protocol().equals(uri.getScheme()); + LOG.debug("connect to hbase cluster with rpc bootstrap servers='{}'", uri.getAuthority()); + Configuration c = new Configuration(conf); + c.set(RpcConnectionRegistry.BOOTSTRAP_NODES, uri.getAuthority()); + return new RpcConnectionRegistry(c, user); + } + + @Override + public String protocol() { + return "hbase+rpc"; Review Comment: I suppose, the way to think about this connection URI is that is it just for locating and initiating a connection to a cluster. Even if we were to pursue a more complete specification as I've advocated, a client still has non-trivial reliance on other configuration parameters. It's unrealistic to expect that we could roll up those details in the scheme portion of the URI. You've convinced me. Given the menu of options that we have available today, what you have implemented here seems fine. Can we add "hbase" without the "+..." part and let that be the default bootstrap mechanism for the current hbase version? In 2.6 that would be an alias for hbase+zk, for 3.0 that would be an alias for hbase+rpc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
