petersomogyi commented on code in PR #5605:
URL: https://github.com/apache/hbase/pull/5605#discussion_r1559594087
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/PrefetchExecutor.java:
##########
@@ -41,23 +44,30 @@
public final class PrefetchExecutor {
private static final Logger LOG =
LoggerFactory.getLogger(PrefetchExecutor.class);
+ /** Wait time in miliseconds before executing prefetch */
+ public static final String PREFETCH_DELAY = "hbase.hfile.prefetch.delay";
+ public static final String PREFETCH_DELAY_VARIATION =
"hbase.hfile.prefetch.delay.variation";
+ public static final float PREFETCH_DELAY_VARIATION_DEFAULT_VALUE = 0.2f;
/** Futures for tracking block prefetch activity */
- private static final Map<Path, Future<?>> prefetchFutures = new
ConcurrentSkipListMap<>();
+ public static final Map<Path, Future<?>> prefetchFutures = new
ConcurrentSkipListMap<>();
Review Comment:
Can be private.
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/PrefetchExecutor.java:
##########
@@ -41,23 +44,30 @@
public final class PrefetchExecutor {
private static final Logger LOG =
LoggerFactory.getLogger(PrefetchExecutor.class);
+ /** Wait time in miliseconds before executing prefetch */
+ public static final String PREFETCH_DELAY = "hbase.hfile.prefetch.delay";
+ public static final String PREFETCH_DELAY_VARIATION =
"hbase.hfile.prefetch.delay.variation";
+ public static final float PREFETCH_DELAY_VARIATION_DEFAULT_VALUE = 0.2f;
/** Futures for tracking block prefetch activity */
- private static final Map<Path, Future<?>> prefetchFutures = new
ConcurrentSkipListMap<>();
+ public static final Map<Path, Future<?>> prefetchFutures = new
ConcurrentSkipListMap<>();
+ /** Runnables for resetting the prefetch activity */
+ public static final Map<Path, Runnable> prefetchRunnable = new
ConcurrentSkipListMap<>();
/** Executor pool shared among all HFiles for block prefetch */
- private static final ScheduledExecutorService prefetchExecutorPool;
+ public static final ScheduledExecutorService prefetchExecutorPool;
Review Comment:
Can be private.
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/PrefetchExecutor.java:
##########
@@ -41,23 +44,30 @@
public final class PrefetchExecutor {
private static final Logger LOG =
LoggerFactory.getLogger(PrefetchExecutor.class);
+ /** Wait time in miliseconds before executing prefetch */
+ public static final String PREFETCH_DELAY = "hbase.hfile.prefetch.delay";
+ public static final String PREFETCH_DELAY_VARIATION =
"hbase.hfile.prefetch.delay.variation";
+ public static final float PREFETCH_DELAY_VARIATION_DEFAULT_VALUE = 0.2f;
/** Futures for tracking block prefetch activity */
- private static final Map<Path, Future<?>> prefetchFutures = new
ConcurrentSkipListMap<>();
+ public static final Map<Path, Future<?>> prefetchFutures = new
ConcurrentSkipListMap<>();
+ /** Runnables for resetting the prefetch activity */
+ public static final Map<Path, Runnable> prefetchRunnable = new
ConcurrentSkipListMap<>();
Review Comment:
Can be private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
