[
https://issues.apache.org/jira/browse/HBASE-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421104#comment-13421104
]
Lars Hofhansl commented on HBASE-5659:
--------------------------------------
>From Store.commitFile(...)
{code}
StoreFile sf = new StoreFile(this.fs, dstPath, this.conf, this.cacheConf,
this.family.getBloomFilterType(), this.dataBlockEncoder);
passSchemaMetricsTo(sf);
StoreFile.Reader r = sf.createReader();
this.storeSize += r.length();
this.totalUncompressedBytes += r.getTotalUncompressedBytes();
{code}
The created reader then is not closed. Is that by design (i.e. the reader is
preopened for performance, because we expect the flushed file to be read soon),
or is this an oversight?
Maybe somebody else could have a look?
> TestAtomicOperation.testMultiRowMutationMultiThreads is still failing
> occasionally
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5659
> URL: https://issues.apache.org/jira/browse/HBASE-5659
> Project: HBase
> Issue Type: Sub-task
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Minor
> Fix For: 0.96.0, 0.94.1
>
> Attachments: 5659-v2.txt, 5659.txt
>
>
> See run here:
> https://builds.apache.org/job/PreCommit-HBASE-Build/1318//testReport/org.apache.hadoop.hbase.regionserver/TestAtomicOperation/testMultiRowMutationMultiThreads/
> {quote}
> 2012-03-27 04:36:12,627 DEBUG [Thread-118] regionserver.StoreScanner(499):
> Storescanner.peek() is changed where before =
> rowB/colfamily11:qual1/7202/Put/vlen=6/ts=7922,and after =
> rowB/colfamily11:qual1/7199/DeleteColumn/vlen=0/ts=0
> 2012-03-27 04:36:12,629 INFO [Thread-121] regionserver.HRegion(1558):
> Finished memstore flush of ~2.9k/2952, currentsize=1.6k/1640 for region
> testtable,,1332822963417.7cd30e219714cfc5e91f69def66e7f81. in 14ms,
> sequenceid=7927, compaction requested=true
> 2012-03-27 04:36:12,629 DEBUG [Thread-126]
> regionserver.TestAtomicOperation$2(362): flushing
> 2012-03-27 04:36:12,630 DEBUG [Thread-126] regionserver.HRegion(1426):
> Started memstore flush for
> testtable,,1332822963417.7cd30e219714cfc5e91f69def66e7f81., current region
> memstore size 1.9k
> 2012-03-27 04:36:12,630 DEBUG [Thread-126] regionserver.HRegion(1474):
> Finished snapshotting
> testtable,,1332822963417.7cd30e219714cfc5e91f69def66e7f81., commencing wait
> for mvcc, flushsize=1968
> 2012-03-27 04:36:12,630 DEBUG [Thread-126] regionserver.HRegion(1484):
> Finished snapshotting, commencing flushing stores
> 2012-03-27 04:36:12,630 DEBUG [Thread-126] util.FSUtils(153): Creating
> file=/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/target/test-data/b9091c3c-961e-4035-850a-83ad14d517cc/TestAtomicOperationtestMultiRowMutationMultiThreads/testtable/7cd30e219714cfc5e91f69def66e7f81/.tmp/61954619003e469baf1a34be5ff2ec57
> with permission=rwxrwxrwx
> 2012-03-27 04:36:12,631 DEBUG [Thread-126] hfile.HFileWriterV2(143):
> Initialized with CacheConfig:enabled [cacheDataOnRead=true]
> [cacheDataOnWrite=false] [cacheIndexesOnWrite=false]
> [cacheBloomsOnWrite=false] [cacheEvictOnClose=false] [cacheCompressed=false]
> 2012-03-27 04:36:12,631 INFO [Thread-126]
> regionserver.StoreFile$Writer(997): Delete Family Bloom filter type for
> /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/target/test-data/b9091c3c-961e-4035-850a-83ad14d517cc/TestAtomicOperationtestMultiRowMutationMultiThreads/testtable/7cd30e219714cfc5e91f69def66e7f81/.tmp/61954619003e469baf1a34be5ff2ec57:
> CompoundBloomFilterWriter
> 2012-03-27 04:36:12,632 INFO [Thread-126]
> regionserver.StoreFile$Writer(1220): NO General Bloom and NO DeleteFamily was
> added to HFile
> (/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/target/test-data/b9091c3c-961e-4035-850a-83ad14d517cc/TestAtomicOperationtestMultiRowMutationMultiThreads/testtable/7cd30e219714cfc5e91f69def66e7f81/.tmp/61954619003e469baf1a34be5ff2ec57)
>
> 2012-03-27 04:36:12,632 INFO [Thread-126] regionserver.Store(770): Flushed ,
> sequenceid=7934, memsize=1.9k, into tmp file
> /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/target/test-data/b9091c3c-961e-4035-850a-83ad14d517cc/TestAtomicOperationtestMultiRowMutationMultiThreads/testtable/7cd30e219714cfc5e91f69def66e7f81/.tmp/61954619003e469baf1a34be5ff2ec57
> 2012-03-27 04:36:12,632 DEBUG [Thread-126] regionserver.Store(795): Renaming
> flushed file at
> /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/target/test-data/b9091c3c-961e-4035-850a-83ad14d517cc/TestAtomicOperationtestMultiRowMutationMultiThreads/testtable/7cd30e219714cfc5e91f69def66e7f81/.tmp/61954619003e469baf1a34be5ff2ec57
> to
> /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/target/test-data/b9091c3c-961e-4035-850a-83ad14d517cc/TestAtomicOperationtestMultiRowMutationMultiThreads/testtable/7cd30e219714cfc5e91f69def66e7f81/colfamily11/61954619003e469baf1a34be5ff2ec57
> 2012-03-27 04:36:12,634 INFO [Thread-126] regionserver.Store(818): Added
> /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/target/test-data/b9091c3c-961e-4035-850a-83ad14d517cc/TestAtomicOperationtestMultiRowMutationMultiThreads/testtable/7cd30e219714cfc5e91f69def66e7f81/colfamily11/61954619003e469baf1a34be5ff2ec57,
> entries=12, sequenceid=7934, filesize=1.3k
> 2012-03-27 04:36:12,642 DEBUG [Thread-118]
> regionserver.TestAtomicOperation$2(392): []
> Exception in thread "Thread-118" junit.framework.AssertionFailedError at
> junit.framework.Assert.fail(Assert.java:48)
> at junit.framework.Assert.fail(Assert.java:56)
> at
> org.apache.hadoop.hbase.regionserver.TestAtomicOperation$2.run(TestAtomicOperation.java:394)
> 2012-03-27 04:36:12,643 INFO [Thread-126] regionserver.HRegion(1558):
> Finished memstore flush of ~1.9k/1968, currentsize=1.3k/1312 for region
> testtable,,1332822963417.7cd30e219714cfc5e91f69def66e7f81. in 14ms,
> sequenceid=7934, compaction requested=true
> {quote}
> I think this issue is different from parent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
