jhungund commented on code in PR #5826:
URL: https://github.com/apache/hbase/pull/5826#discussion_r1566860086
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePreadReader.java:
##########
@@ -79,7 +79,7 @@ public void run() {
// so we check first if the block exists on its in-memory index,
if so, we just
// update the offset and move on to the next block without
actually going read all
// the way to the cache.
- BlockCacheKey cacheKey = new BlockCacheKey(name, offset);
+ BlockCacheKey cacheKey = new BlockCacheKey(path, offset, true,
BlockType.DATA);
Review Comment:
The constructor used earlier(BlockCacheKey(name, offset);) sets these
parameters internally. Hence, I used these parameters:
public BlockCacheKey(String hfileName, long offset) {
this(hfileName, offset, true, BlockType.DATA);
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
