BukrosSzabolcs commented on code in PR #5785:
URL: https://github.com/apache/hbase/pull/5785#discussion_r1566941715
##########
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java:
##########
@@ -110,6 +112,23 @@ public static RecoverableZooKeeper connect(Configuration
conf, String ensemble,
*/
public static RecoverableZooKeeper connect(Configuration conf, String
ensemble, Watcher watcher,
final String identifier) throws IOException {
+ return connect(conf, ensemble, watcher, identifier, null);
Review Comment:
Technically it would not make a difference, because the ZooKeeper code we
end up calling would just create a new ZKClientConfig when a null is passed.
I implemented it like this to signal where the config should be modified if
needed. I pass a null for use cases where the config was not passed and we
expect to use the default. But I pass the instance where I expect it to be
modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
