vinayakphegde commented on code in PR #5832:
URL: https://github.com/apache/hbase/pull/5832#discussion_r1568930833
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketProtoUtils.java:
##########
@@ -130,10 +136,30 @@ static Pair<ConcurrentHashMap<BlockCacheKey,
BucketEntry>, NavigableSet<BlockCac
ConcurrentHashMap<BlockCacheKey, BucketEntry> result = new
ConcurrentHashMap<>();
NavigableSet<BlockCacheKey> resultSet = new
ConcurrentSkipListSet<>(Comparator
.comparing(BlockCacheKey::getHfileName).thenComparingLong(BlockCacheKey::getOffset));
+
+ Map<String, Path> allFilePaths = null;
+ DataTieringManager dataTieringManager;
+ try {
+ dataTieringManager = DataTieringManager.getInstance();
+ allFilePaths = dataTieringManager.getAllFilesList();
+ } catch (IllegalStateException e) {
+ // Data-Tiering manager has not been set up.
+ // Ignore the error and proceed with the normal flow.
+ LOG.warn("Error while getting DataTieringManager instance: {}",
e.getMessage());
+ }
+
for (BucketCacheProtos.BackingMapEntry entry : backingMap.getEntryList()) {
BucketCacheProtos.BlockCacheKey protoKey = entry.getKey();
- BlockCacheKey key = new BlockCacheKey(protoKey.getHfilename(),
protoKey.getOffset(),
- protoKey.getPrimaryReplicaBlock(), fromPb(protoKey.getBlockType()));
+
+ BlockCacheKey key = null;
+ if (allFilePaths != null) {
+ key = new BlockCacheKey(allFilePaths.get(protoKey.getHfilename()),
protoKey.getOffset(),
+ protoKey.getPrimaryReplicaBlock(), fromPb(protoKey.getBlockType()));
+ } else {
+ key = new BlockCacheKey(new Path(protoKey.getHfilename()),
protoKey.getOffset(),
Review Comment:
The path will be incorrect, right? Anyone who accesses it will find the
incorrect path.
However, I couldn't think of any solution for that. @wchevreuil, do you have
any thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
