gvprathyusha6 commented on code in PR #5834:
URL: https://github.com/apache/hbase/pull/5834#discussion_r1571002658
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/DefaultStoreFileTracker.java:
##########
@@ -55,12 +65,49 @@ protected void
doAddCompactionResults(Collection<StoreFileInfo> compactedFiles,
@Override
protected List<StoreFileInfo> doLoadStoreFiles(boolean readOnly) throws
IOException {
- List<StoreFileInfo> files =
-
ctx.getRegionFileSystem().getStoreFiles(ctx.getFamily().getNameAsString());
+ List<StoreFileInfo> files =
getStoreFiles(ctx.getFamily().getNameAsString(), true);
return files != null ? files : Collections.emptyList();
}
@Override
protected void doSetStoreFiles(Collection<StoreFileInfo> files) throws
IOException {
}
+
+ /**
+ * Returns the store files available for the family. This methods performs
the filtering based on
+ * the valid store files.
+ * @param familyName Column Family Name
+ * @return a set of {@link StoreFileInfo} for the specified family.
+ */
+ public List<StoreFileInfo> getStoreFiles(final String familyName, final
boolean validate)
Review Comment:
This is only helper method used as part of SFT#load() impl of
DefaultStoreFileTracker, this was moved from
[HRegionFileSystem](https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java#L274)
to here. This is not a new API we are adding
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
