junegunn commented on code in PR #5849:
URL: https://github.com/apache/hbase/pull/5849#discussion_r1577521472
##########
hbase-shell/src/main/ruby/hbase/table.rb:
##########
@@ -833,16 +833,16 @@ def convert_bytes(bytes, converter_class = nil,
converter_method = nil)
eval(converter_class).method(converter_method).call(bytes)
end
- def convert_bytes_with_position(bytes, offset, len, converter_class,
converter_method)
- # Avoid nil
- converter_class ||= 'org.apache.hadoop.hbase.util.Bytes'
- converter_method ||= 'toStringBinary'
- eval(converter_class).method(converter_method).call(bytes, offset, len)
- end
-
# store the information designating what part of a column should be
printed, and how
ColumnFormatSpec = Struct.new(:family, :qualifier, :converter)
+ # Use this instead of parse_column_name if the name cannot contain a
converter
+ private def split_column_name(column)
+ # NOTE: We use 'take(2)' insteaad of 'to_a' to avoid type coercion of
the nested byte arrays.
Review Comment:
```suggestion
# NOTE: We use 'take(2)' instead of 'to_a' to avoid type coercion of
the nested byte arrays.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
