hgromer commented on code in PR #5819:
URL: https://github.com/apache/hbase/pull/5819#discussion_r1581276705


##########
hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerConfig.java:
##########
@@ -117,6 +121,10 @@ public Map<TableName, List<String>> 
getExcludeTableCFsMap() {
     return (Map<TableName, List<String>>) excludeTableCFsMap;
   }
 

Review Comment:
   I added this method to the builder in the [initial 
commit](https://github.com/apache/hbase/pull/5819/files#diff-4111cec0f23deab9e2827446de52e105d46d5f91e8f66b9a0c60e495b236d1e6R250).
 I asked this question because I noticed ReplicationPeerConfig has some 
deprecated setter methods. I wasn't sure if it would make sense to introduce a 
deprecated setter for this new field to follow the existing code, or if I 
should leave it out for this new field.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to