Apache9 commented on code in PR #5869:
URL: https://github.com/apache/hbase/pull/5869#discussion_r1589993413
##########
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKMainServer.java:
##########
@@ -41,7 +42,8 @@ public String parse(final Configuration c) {
* ZooKeeper 3.4.6 broke being able to pass commands on command line. See
ZOOKEEPER-1897. This
* class is a hack to restore this faclity.
*/
- private static class HACK_UNTIL_ZOOKEEPER_1897_ZooKeeperMain extends
ZooKeeperMain {
+ private static class HACK_UNTIL_ZOOKEEPER_1897_ZooKeeperMain extends
ZooKeeperMain
+ implements Closeable {
Review Comment:
We have bumped our zookeeper dependency to 3.8.x, do we still need this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
