Apache9 commented on PR #5874: URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095053926
> Sure but right now the problem is `ZKWatcher#filterMetaReplicaNodes` returns empty List if the input nodes is null. So `MetaRegionLocationCache` can't tell the difference between: > > * node exists but has no children > * node does not exist > > So seems like we might need to change `ZKWatcher` either way. It is just a bit strange that in ZKUtil we eat the NoNodeException while at the upper layer we create a new NoNodeException and throw it... Better just return null in ZKWatcher, and in MetaRegionLocationCache, we do not break the loop if the return value is null. WDYT? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
