rmdmattingly commented on code in PR #5876:
URL: https://github.com/apache/hbase/pull/5876#discussion_r1594113045
##########
hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupDelete.java:
##########
@@ -158,4 +160,27 @@ public long currentTime() {
LOG.info(baos.toString());
assertTrue(output.indexOf("Deleted 1 backups") >= 0);
}
+
+ /**
+ * Verify that backup deletion updates the incremental-backup-set.
+ */
+ @Test
+ public void testBackupDeleteUpdatesIncrementalBackupSet() throws Exception {
+ LOG.info("Test backup delete updates the incremental backup set");
+ BackupSystemTable backupSystemTable = new
BackupSystemTable(TEST_UTIL.getConnection());
+
+ String backupId1 = fullTableBackup(Lists.newArrayList(table1, table2));
+ assertTrue(checkSucceeded(backupId1));
+ assertEquals(Sets.newHashSet(table1, table2),
+ backupSystemTable.getIncrementalBackupTableSet(BACKUP_ROOT_DIR));
+
+ String backupId2 = fullTableBackup(Lists.newArrayList(table3));
+ assertTrue(checkSucceeded(backupId1));
Review Comment:
typo: I think you want to check the success of `backupId2` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
