gvprathyusha6 commented on code in PR #5307:
URL: https://github.com/apache/hbase/pull/5307#discussion_r1596614929
##########
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java:
##########
@@ -2308,7 +2316,7 @@ protected byte[] generateRow(final int i) {
}
@Override
- boolean testRow(final int i, final long startTime) throws IOException {
+ protected boolean testRow(final int i, final long startTime) throws
IOException {
Review Comment:
>But the methods in TestBase class are all package private? Even if you
change this to protected, you can not inherit this class in other package
because you can not call the constructor?
Rest I am able to manage with by putting my impl classes in package with
same name as PE, but without protected on SequentialWriteTest.testRow I am not
able to override that method in my impl test class.
##########
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java:
##########
@@ -2308,7 +2316,7 @@ protected byte[] generateRow(final int i) {
}
@Override
- boolean testRow(final int i, final long startTime) throws IOException {
+ protected boolean testRow(final int i, final long startTime) throws
IOException {
Review Comment:
Rest I am able to manage with by putting my impl classes in package with
same name as PE, but without protected on SequentialWriteTest.testRow I am not
able to override that method in my impl test class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
