Apache9 commented on code in PR #5893:
URL: https://github.com/apache/hbase/pull/5893#discussion_r1598529826
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java:
##########
@@ -686,12 +686,6 @@ public void abortCacheFlush(byte[] encodedRegionName) {
this.sequenceIdAccounting.abortCacheFlush(encodedRegionName);
}
- @Override
- public long getEarliestMemStoreSeqNum(byte[] encodedRegionName) {
- // Used by tests. Deprecated as too subtle for general usage.
- return this.sequenceIdAccounting.getLowestSequenceId(encodedRegionName);
Review Comment:
Does this method in SequenceIdAccounting still useful?
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestPerColumnFamilyFlush.java:
##########
@@ -162,8 +162,8 @@ public void testSelectiveFlushWhenEnabled() throws
IOException {
MemStoreSize cf3MemstoreSize = region.getStore(FAMILY3).getMemStoreSize();
// Get the overall smallest LSN in the region's memstores.
- long smallestSeqInRegionCurrentMemstore =
-
getWAL(region).getEarliestMemStoreSeqNum(region.getRegionInfo().getEncodedNameAsBytes());
+ long smallestSeqInRegionCurrentMemstore = getWAL(region)
+
.getEarliestMemStoreSeqNum(region.getRegionInfo().getEncodedNameAsBytes(),
FAMILY1);
Review Comment:
Is this the correct way to change the UT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
