[ 
https://issues.apache.org/jira/browse/HBASE-5705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422971#comment-13422971
 ] 

stack commented on HBASE-5705:
------------------------------

All of above seems reasonable.  Here is some response.

bq. ...Could you please point me to the block of code in the patch where this 
is.

I do not see it now.

bq. ...and in the case of ProtobufRpcEngine, they are done using 
RpcRequestWritable (a thin wrapper over PB objects).

The Writable wrapper goes away when we move to pb engine?

bq. ...In that sense, we need the message size.

Its header length only right?   Thats ok I'd say.  But for the value, when its 
a 50M cell, we won't have to read it into a buffer to find its size before 
sending will we when we are pb?  (pb does this internally probably but we do we 
have to do it again outside of pb to put it in rpc header?)


                
> Introduce Protocol Buffer RPC engine
> ------------------------------------
>
>                 Key: HBASE-5705
>                 URL: https://issues.apache.org/jira/browse/HBASE-5705
>             Project: HBase
>          Issue Type: Sub-task
>          Components: ipc, master, migration, regionserver
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.96.0
>
>         Attachments: 5705-1.patch, 5705-2.1.patch, 5705-2.2.patch
>
>
> Introduce Protocol Buffer RPC engine in the RPC core. Protocols that are PB 
> aware can be made to go through this RPC engine. The approach, in my current 
> thinking, would be similar to HADOOP-7773.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to