Apache9 commented on code in PR #5910:
URL: https://github.com/apache/hbase/pull/5910#discussion_r1604312448


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java:
##########
@@ -3787,7 +3798,7 @@ private void closeScanner(HRegion region, RegionScanner 
scanner, String scannerN
       if (region.getCoprocessorHost() != null) {
         region.getCoprocessorHost().postScannerClose(scanner);
       }
-      closedScanners.put(scannerName, scannerName);
+      if (!isError) closedScanners.put(scannerName, rsh.getNextCallSeq());

Review Comment:
   The checkstyle config for HBase will issue a warning for this style, please 
use
   ```
   if (!isError) {
     xxx
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to