jhungund commented on code in PR #5905:
URL: https://github.com/apache/hbase/pull/5905#discussion_r1604512006
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java:
##########
@@ -275,6 +275,18 @@ public boolean shouldCacheBlockOnRead(BlockCategory
category) {
|| (prefetchOnOpen && (category != BlockCategory.META && category !=
BlockCategory.UNKNOWN));
}
+ public boolean shouldCacheFileBlock(HFileInfo hFileInfo, Configuration conf)
{
+ Optional<Boolean> cacheFileBlock = Optional.of(true);
+ // Additionally perform the time-based priority checks to see
+ // whether, or not to cache the block.
+ if (getBlockCache().isPresent()) {
+
+ cacheFileBlock = getBlockCache().get().shouldCacheFile(hFileInfo, conf);
+ LOG.info("BlockCache Present, cacheFileBlock: {}", cacheFileBlock.get());
Review Comment:
I had added to to debug something. Needs to be cleaned up. thanks for
pointing this out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
