[
https://issues.apache.org/jira/browse/HBASE-28568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17847576#comment-17847576
]
Hudson commented on HBASE-28568:
--------------------------------
Results for branch master
[build #1074 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1074/]:
(x) *{color:red}-1 overall{color}*
----
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1074/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1074//console].
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1074/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Incremental backup set does not correctly shrink
> ------------------------------------------------
>
> Key: HBASE-28568
> URL: https://issues.apache.org/jira/browse/HBASE-28568
> Project: HBase
> Issue Type: Bug
> Components: backup&restore
> Affects Versions: 2.6.0, 3.0.0
> Reporter: Dieter De Paepe
> Assignee: Dieter De Paepe
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0-alpha-1, 2.7.0, 3.0.0-beta-2, 2.6.1
>
>
> The logic in BackupAdminImpl#finalizeDelete does not properly clean up tables
> from the incrementalBackupTableSet (= the set of backups to include in every
> incremental backup).
> This can lead to backups failing.
>
> Minimal example to reproduce from source:
> * Add following to `conf/hbase-site.xml` to enable backups:
> {code:java}
> <property>
> <name>hbase.backup.enable</name>
> <value>true</value>
> </property>
> <property>
> <name>hbase.master.logcleaner.plugins</name>
>
> <value>org.apache.hadoop.hbase.master.cleaner.TimeToLiveLogCleaner,org.apache.hadoop.hbase.master.cleaner.TimeToLiveProcedureWALCleaner,org.apache.hadoop.hbase.master.cleaner.TimeToLiveMasterLocalStoreWALCleaner,org.apache.hadoop.hbase.backup.master.BackupLogCleaner</value>
> </property>
> <property>
> <name>hbase.procedure.master.classes</name>
>
> <value>org.apache.hadoop.hbase.backup.master.LogRollMasterProcedureManager</value>
> </property>
> <property>
> <name>hbase.procedure.regionserver.classes</name>
>
> <value>org.apache.hadoop.hbase.backup.regionserver.LogRollRegionServerProcedureManager</value>
> </property>
> <property>
> <name>hbase.coprocessor.region.classes</name>
> <value>org.apache.hadoop.hbase.backup.BackupObserver</value>
> </property>
> <property>
> <name>hbase.fs.tmp.dir</name>
> <value>file:/tmp/hbase-tmp</value>
> </property> {code}
> * Start HBase: {{bin/start-hbase.sh}}
> *
> {code:java}
> echo "create 'table1', 'cf'" | bin/hbase shell -n
> echo "create 'table2', 'cf'" | bin/hbase shell -nbin/hbase backup create full
> file:/tmp/hbasebackups -t table1
> bin/hbase backup create full file:/tmp/hbasebackups -t table2
> bin/hbase backup create incremental file:/tmp/hbasebackups
> # Deletes the 2 most recent backups
> bin/hbase backup delete -l $(bin/hbase backup history | head -n1 | tail -n
> -1 | grep -o -P "backup_\d+"),$(bin/hbase backup history | head -n2 | tail
> -n -1 | grep -o -P "backup_\d+")
> bin/hbase backup create incremental file:/tmp/hbasebackups -t table1
> bin/hbase backup history{code}
> * Output shows the incremental backup still includes table2, this should
> only be table1:
> {code:java}
> {ID=backup_1715000053763,Type=INCREMENTAL,Tables={table2,table1},State=COMPLETE,Start
> time=Mon May 06 14:54:14 CEST 2024,End time=Mon May 06 14:54:16 CEST
> 2024,Progress=100%}
> {ID=backup_1715000031407,Type=FULL,Tables={table1},State=COMPLETE,Start
> time=Mon May 06 14:53:52 CEST 2024,End time=Mon May 06 14:53:54 CEST
> 2024,Progress=100%}
> {code}
> PR will follow soon.
> (Edited: my original ticket included a stacktrace of an IllegalStateException
> from a PR for HBASE-28562)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
