wchevreuil commented on code in PR #5906:
URL: https://github.com/apache/hbase/pull/5906#discussion_r1606971440
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java:
##########
@@ -1336,7 +1341,7 @@ public HFileBlock readBlock(long dataBlockOffset, long
onDiskBlockSize, final bo
return cachedBlock;
}
- if (!useLock && cacheable &&
cacheConf.shouldLockOnCacheMiss(expectedBlockType)) {
+ if (!useLock && cacheBlock &&
cacheConf.shouldLockOnCacheMiss(expectedBlockType)) {
Review Comment:
In HBASE-27474, we were only caching refs if compaction was off. Here we are
modifying this behaviour. We'll let the cache implementation decide how to
handle refs. For BucketCache, we are modifying it to first resolve the ref and
check for the referred file block. If it's not cache, it will cache the ref as
the block cache key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
