stoty commented on code in PR #5955:
URL: https://github.com/apache/hbase/pull/5955#discussion_r1624781852
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterListWithAND.java:
##########
@@ -206,17 +244,28 @@ public boolean filterRowKey(Cell firstRowCell) throws
IOException {
if (isEmpty()) {
return super.filterRowKey(firstRowCell);
}
- boolean retVal = false;
+ boolean anyRowKeyFiltered = false;
+ boolean anyHintingPassed = false;
for (int i = 0, n = filters.size(); i < n; i++) {
Filter filter = filters.get(i);
- if (filter.filterAllRemaining() || filter.filterRowKey(firstRowCell)) {
+ if (filter.filterAllRemaining()) {
Review Comment:
Technically no, but we do it anyway everywhere, so I didn't want to remove
it just here.
There is also an MR job that possibly requires this.
I have opened HBASE-28633 for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
