Apache9 commented on code in PR #5974:
URL: https://github.com/apache/hbase/pull/5974#discussion_r1634456264
##########
hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/model/CellModel.java:
##########
@@ -218,9 +218,10 @@ public Message messageFromObject() {
}
@Override
- public ProtobufMessageHandler getObjectFromMessage(byte[] message) throws
IOException {
+ public ProtobufMessageHandler getObjectFromMessage(CodedInputStream cis)
throws IOException {
Cell.Builder builder = Cell.newBuilder();
- ProtobufUtil.mergeFrom(builder, message);
+ builder.mergeFrom(cis);
Review Comment:
Better still introduce a method in ProtobufUtil to put these two lines?
Otherwise we need to repeat these two lines in every classes. And why we need
to call checkLastTagWas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
