Apache9 commented on code in PR #5906:
URL: https://github.com/apache/hbase/pull/5906#discussion_r1639805560
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java:
##########
@@ -1336,7 +1341,7 @@ public HFileBlock readBlock(long dataBlockOffset, long
onDiskBlockSize, final bo
return cachedBlock;
}
- if (!useLock && cacheable &&
cacheConf.shouldLockOnCacheMiss(expectedBlockType)) {
+ if (!useLock && cacheBlock &&
cacheConf.shouldLockOnCacheMiss(expectedBlockType)) {
Review Comment:
Same as above, better add some comments to explain the history~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
