virajjasani commented on code in PR #5837:
URL: https://github.com/apache/hbase/pull/5837#discussion_r1640383572


##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ZKConnectionRegistry.java:
##########
@@ -69,39 +73,85 @@ class ZKConnectionRegistry implements ConnectionRegistry {
   private final ReadOnlyZKClient zk;
 
   private final ZNodePaths znodePaths;
+  private final Configuration conf;
+
+  public static final String EXPECTED_TIMEOUT = "expected.timeout";
+  public static final int DEFAULT_EXPECTED_TIMEOUT = 200000;

Review Comment:
   Let's keep it this way:
   
   ```
     public static final String ZK_REGISTRY_ASYNC_GET_TIMEOUT = 
"zookeeper.registry.async.get.timeout";
     public static final int DEFAULT_ZK_REGISTRY_ASYNC_GET_TIMEOUT = 60000; // 
1 min
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to