[
https://issues.apache.org/jira/browse/HBASE-28680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17856897#comment-17856897
]
Hudson commented on HBASE-28680:
--------------------------------
Results for branch branch-2.6
[build #147 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/147/]:
(x) *{color:red}-1 overall{color}*
----
details (if available):
(x) {color:red}-1 general checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/147//console].
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/147/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/147/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/147/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> BackupLogCleaner causes HMaster WALs to pile up indefinitely
> ------------------------------------------------------------
>
> Key: HBASE-28680
> URL: https://issues.apache.org/jira/browse/HBASE-28680
> Project: HBase
> Issue Type: Bug
> Components: backup&restore, master
> Affects Versions: 2.6.0
> Reporter: Ray Mattingly
> Assignee: Ray Mattingly
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0-alpha-1, 2.7.0, 3.0.0-beta-2, 2.6.1
>
>
> We have been trying to setup daily incremental backups for hundreds of
> clusters at my day job. Recently we discovered that old WALs were piling up
> across many clusters inline with when we began running incremental backups.
> This led to the realization that [the BackupLogCleaner will always skip
> archived HMaster
> WALs|https://github.com/HubSpot/hbase/blob/3a170578b04d5947c655319f1b8d8475ccb6bb4e/hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/util/BackupUtils.java#L364-L367].
> This is a problem because, if a cleaner is skipping a given file, then [the
> CleanerChore will never delete
> it|https://github.com/apache/hbase/blob/fb988373c1cd0184400fe17c4323fbf0de07c951/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java#L312-L332].
> This seems like a misunderstanding of what it means to "skip" a WAL in a
> BaseLogCleanerDelegate, and, instead, we should always return these HMaster
> WALs as deletable from the perspective of the BackupLogCleaner. We could
> subject them to the same scrutiny as RegionServer WALs: are they older than
> the most recent successful backup? But, if I understand correctly, HMaster
> WALs do not contain any data relevant to table backups, so that would be
> unnecessary.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
