virajjasani commented on code in PR #6041:
URL: https://github.com/apache/hbase/pull/6041#discussion_r1663177932
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java:
##########
@@ -1208,4 +1211,16 @@ DatanodeInfo[] getPipeline() {
}
return new DatanodeInfo[0];
}
+
+ Writer getWriter() {
+ return this.writer;
+ }
Review Comment:
We can remove this since it is similar to parent method
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java:
##########
@@ -1208,4 +1211,16 @@ DatanodeInfo[] getPipeline() {
}
return new DatanodeInfo[0];
}
+
+ Writer getWriter() {
+ return this.writer;
+ }
+
+ void setWriter(Writer writer) {
+ this.writer = writer;
+ }
+
+ protected int getClosedErrorCount() {
+ return closeErrorCount.get();
+ }
Review Comment:
To indicate that these are mostly visible for testing:
```
// Visible for testing
@InterfaceAudience.Private
void setWriter(Writer writer) {
this.writer = writer;
}
// Visible for testing
@InterfaceAudience.Private
protected int getClosedErrorCount() {
return closeErrorCount.get();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
