Apache9 commented on code in PR #6017:
URL: https://github.com/apache/hbase/pull/6017#discussion_r1663618075
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/mapreduce/MapReduceBackupCopyJob.java:
##########
@@ -425,4 +435,25 @@ public void cancel(String jobId) throws IOException {
}
}
+ protected static List<String> parseDistCpOptions(Configuration conf) {
+ List<String> extraArgsFromConf = new ArrayList<>();
+
+ for (DistCpOptionSwitch optionSwitch : DistCpOptionSwitch.values()) {
+ String configLabel = optionSwitch.getConfigLabel();
+ if (conf.get(configLabel) != null) {
Review Comment:
Do we want to add some prefix for these distcp configs?
Like [hbase.backup.copy.]distcp.xxxx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]