pankaj72981 commented on code in PR #6054:
URL: https://github.com/apache/hbase/pull/6054#discussion_r1670729481
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java:
##########
@@ -3159,7 +3159,7 @@ public QuotaRetriever getQuotaRetriever(final QuotaFilter
filter) throws IOExcep
@Override
public List<QuotaSettings> getQuota(QuotaFilter filter) throws IOException {
List<QuotaSettings> quotas = new ArrayList<>();
- try (QuotaRetriever retriever = QuotaRetriever.open(conf, filter)) {
+ try (QuotaRetriever retriever = QuotaRetriever.open(connection, filter)) {
Iterator<QuotaSettings> iterator = retriever.iterator();
Review Comment:
Changes looks good to me.
However similar optimization can be done in master branch as well, below API
is used multiple places
`org.apache.hadoop.hbase.quotas.QuotaRetriever#open(org.apache.hadoop.conf.Configuration,
org.apache.hadoop.hbase.quotas.QuotaFilter)`
We can reuse the existing connection instead of creating new one always.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
