[
https://issues.apache.org/jira/browse/HBASE-28716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles Connell updated HBASE-28716:
------------------------------------
Description: Every call to {{HBaseAdmin#getQuota()}} opens a new
{{Connection}}, and then closes it. As far as I can tell, this is pointless,
since it could use the existing {{Connection}} object held by the
{{HBaseAdmin}}. If you have a custom RpcClient (like we do at Hubspot), new
connections have an expense that we'd rather not pay unnecessarily. I'll submit
a PR that addresses this situation and similar ones. (was: Every call to
{{HBaseAdmin#getQuota()}} opens a new {{Connection}}, and then closes it. As
far as I can tell, this is pointless, since it could use the existing
{{Connection}} object held by the {{HBaseAdmin}}. If you have a custom
RpcClient (like we do at Hubspot), new connections have an expense that we'd
rather not pay unnecessarily. I'll submit a PR. This bug only affects the 2.x
series since {{HBaseAdmin}} is gone in 3.x.)
> Users of QuotaRetriever should pass an existing connection
> ----------------------------------------------------------
>
> Key: HBASE-28716
> URL: https://issues.apache.org/jira/browse/HBASE-28716
> Project: HBase
> Issue Type: Bug
> Components: Admin
> Affects Versions: 2.6.0
> Reporter: Charles Connell
> Assignee: Charles Connell
> Priority: Minor
> Labels: pull-request-available
>
> Every call to {{HBaseAdmin#getQuota()}} opens a new {{Connection}}, and then
> closes it. As far as I can tell, this is pointless, since it could use the
> existing {{Connection}} object held by the {{HBaseAdmin}}. If you have a
> custom RpcClient (like we do at Hubspot), new connections have an expense
> that we'd rather not pay unnecessarily. I'll submit a PR that addresses this
> situation and similar ones.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
