stoty commented on code in PR #6075:
URL: https://github.com/apache/hbase/pull/6075#discussion_r1677399511
##########
hbase-rest/pom.xml:
##########
@@ -368,9 +370,17 @@
<goal>compile</goal>
</goals>
<phase>generate-sources</phase>
+ <configuration>
+
<protocArtifact>com.google.protobuf:protoc:${internal.protobuf.version}:exe:${os.detected.classifier}</protocArtifact>
Review Comment:
Yes, we could, but I think that the would hide the difference, and make it
even harder to find which version we use where.
All the different protobuf libraries and compilers are hard enough figure
out already, the current setup at least gives a clue to whoever tries to
decypher it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
