Apache9 commented on code in PR #5837:
URL: https://github.com/apache/hbase/pull/5837#discussion_r1678819489
##########
hbase-zookeeper/src/test/java/org/apache/hadoop/hbase/zookeeper/TestReadOnlyZKClient.java:
##########
@@ -79,6 +84,10 @@ public class TestReadOnlyZKClient {
private static int CHILDREN = 5;
private static ReadOnlyZKClient RO_ZK;
+ static final HashedWheelTimer RETRY_TIMER = new HashedWheelTimer(
Review Comment:
Pealse use 'private static final' since we do not need to expose it to other
classes.
And please shutdown it in afterClass method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
