[
https://issues.apache.org/jira/browse/HBASE-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425592#comment-13425592
]
nkeywal commented on HBASE-6476:
--------------------------------
bq. How hard would it be to add a maven task that checks for that, so we do not
introduce System.currentTimeMillis back in the future?
It could easily be done on the build env, as there is a script that we can
change. We could add a simple grep there.
The proper way would be to run something as pmd, adding rules is not difficult.
But it would require some configuration to distinguish the debt vs. the new
errors. Or we would activate only the totally clean rules.
bq. Would be a problem too, if we globally mess with the EnvironmentEdge.
There are some tests that play with the EnvironmentEdgeManager, they had to be
made medium as it was not possible to have them on a shared jvm as the small
tests.
> Replace all occurrances of System.currentTimeMillis() with EnvironmentEdge
> equivalent
> -------------------------------------------------------------------------------------
>
> Key: HBASE-6476
> URL: https://issues.apache.org/jira/browse/HBASE-6476
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Minor
> Fix For: 0.94.2
>
>
> There are still some areas where System.currentTimeMillis() is used in HBase.
> In order to make all parts of the code base testable and (potentially) to be
> able to configure HBase's notion of time, this should be generally be
> replaced with EnvironmentEdgeManager.currentTimeMillis().
> How hard would it be to add a maven task that checks for that, so we do not
> introduce System.currentTimeMillis back in the future?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
