binlijin created HBASE-6480:
-------------------------------
Summary: If callQueueSize exceed maxQueueSize, all call will be
rejected, do not reject priorityCall
Key: HBASE-6480
URL: https://issues.apache.org/jira/browse/HBASE-6480
Project: HBase
Issue Type: Bug
Reporter: binlijin
Current if the callQueueSize exceed maxQueueSize, all call will be rejected,
Should we let the priority Call pass through?
Current:
if ((callSize + callQueueSize.get()) > maxQueueSize) {
Call callTooBig = xxx
return ;
}
if (priorityCallQueue != null && getQosLevel(param) > highPriorityLevel) {
priorityCallQueue.put(call);
updateCallQueueLenMetrics(priorityCallQueue);
} else {
callQueue.put(call); // queue the call; maybe blocked here
updateCallQueueLenMetrics(callQueue);
}
Should we change it to :
if (priorityCallQueue != null && getQosLevel(param) > highPriorityLevel) {
priorityCallQueue.put(call);
updateCallQueueLenMetrics(priorityCallQueue);
} else {
if ((callSize + callQueueSize.get()) > maxQueueSize) {
Call callTooBig = xxx
return ;
}
callQueue.put(call); // queue the call; maybe blocked here
updateCallQueueLenMetrics(callQueue);
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
