[
https://issues.apache.org/jira/browse/HBASE-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Baranau updated HBASE-6411:
--------------------------------
Attachment: HBASE-6411-4.patch
Uploaded newer diff on review board. Fixed nits.
Note: after trunk update had to remove
{noformat}
public RegionsInTransitionInfo[] getRegionsInTransition()
{noformat}
method from master.metrics.MBean. I believe that this metric is now exposed via
metrics, not via this bean. Please correct me if I'm wrong.
There are two Qs for Elliott inside, pasting here for convenience:
1.
{noformat}
/hbase-server/src/main/java/org/apache/hadoop/hbase/master/metrics/MXBean.java
(Diff revision 1)
18
package org.apache.hadoop.hbase.master.metrics;
{noformat}
Ted:
Should this class be in org.apache.hadoop.hbase.master namespace ?
Alex Baranau:
Hm, I guess we now have two pairs of classes: MXBean and MXBeanImpl in
org.apache.hadoop.hbase.master and in org.apache.hadoop.hbase.master.metrics.
Not sure what was intended by Elliott here. I assume that he forgot to remove
one of them (in org.apache.hadoop.hbase.master? why to move it in metrics
package then?)
Elliott, could you provide some insight here please?
2.
{noformat}
/hbase-server/src/main/java/org/apache/hadoop/hbase/master/metrics/MasterMetrics.java
(Diff revision 1)
63 Deleted:
final MetricsHistogram splitTime = new MetricsHistogram("splitTime",
registry);
{noformat}
We don't maintain such metrics now ?
Alex Baranau
I believe Elliott is working on new such metrics (different issue) and this is
why he removed it. Elliott?
> Move Master Metrics to metrics 2
> --------------------------------
>
> Key: HBASE-6411
> URL: https://issues.apache.org/jira/browse/HBASE-6411
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-6411-0.patch, HBASE-6411-1.patch,
> HBASE-6411-2.patch, HBASE-6411-3.patch, HBASE-6411-4.patch,
> HBASE-6411_concept.patch
>
>
> Move Master Metrics to metrics 2
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
